----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64136/#review192390 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp Lines 1902-1910 (original), 1855-1863 (patched) <https://reviews.apache.org/r/64136/#comment270498> Can we leverage the tracking code for this as well? This code to me is: ``` // Allocate it: slave.allocated += resources; // Track the allocation: trackAllocation(...); ``` Although it's a little unclear to me why the updating of slave.allocated isn't done in the function? Is that not part of tracking an allocation? - Benjamin Mahler On Nov. 29, 2017, 4:27 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64136/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 4:27 p.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This patch introduces a helper to track allocated resources. It > encapsulates all needed updates to the various sorters for > reusability. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c4832b29842330fa57756cd3d4202f265a820f3 > src/master/allocator/mesos/hierarchical.cpp > 5ce9ceaa3a5f84a1e076d45448863c418531cc2b > > > Diff: https://reviews.apache.org/r/64136/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
