----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63631/#review192512 -----------------------------------------------------------
Fix it, then Ship it! The `ProcessBase` and `EventVisitor` relationship is a bit weird already, and I'm a bit concerned about essentially changing the definition of `ProcessBase` across the entire codebase, but I think overall the patch looks consistent and correct. 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 608-609 (original), 608-609 (patched) <https://reviews.apache.org/r/63631/#comment270702> Let's remove this since we're constructing new ones within the `for` loop now. - Michael Park On Nov. 7, 2017, 8:51 a.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63631/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 8:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-6972 > https://issues.apache.org/jira/browse/MESOS-6972 > > > Repository: mesos > > > Description > ------- > > This introduces `EventConsumer` interface, which add support of events > with movable only data. This allows consumers to move data out of > event, rather than copying it. This is required to implement movable > only objects support in `defer` to guarantee that deferred functor is > invoked only once, allowing deferred parameters to be moved into call. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > 2e246205020c3c5b8c2eb5187a8eb3643d1e6d4d > 3rdparty/libprocess/include/process/process.hpp > dc3375ce62556322eb2bc60ade61f313ade123b8 > 3rdparty/libprocess/include/process/protobuf.hpp > fe152f273332470ac50f9715291897bb04cf95b9 > 3rdparty/libprocess/include/process/run.hpp > 1540a78e52a90d4c1d4165c46be353caaad21bce > 3rdparty/libprocess/src/process.cpp > 71ae7129ffbd0e22eda2863b17bbcf588298c37b > 3rdparty/libprocess/src/tests/benchmarks.cpp > e6c77d565d5acf72b475a085e9504679253b4b97 > 3rdparty/libprocess/src/tests/process_tests.cpp > 952c92c033e2363cff0c2c68610d3820b97d177e > > > Diff: https://reviews.apache.org/r/63631/diff/1/ > > > Testing > ------- > > > Thanks, > > Dmitry Zhuk > >
