----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63630/#review192714 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/lambda.hpp Lines 330 (patched) <https://reviews.apache.org/r/63630/#comment270965> `A/Args/` 3rdparty/stout/include/stout/lambda.hpp Lines 345-349 (patched) <https://reviews.apache.org/r/63630/#comment270963> These fit in one line. 3rdparty/stout/include/stout/lambda.hpp Lines 351-354 (patched) <https://reviews.apache.org/r/63630/#comment270964> Can't we just take `A&&... args` as the param types and forward it through like `std::forward<A>(args)...`? 3rdparty/stout/include/stout/lambda.hpp Lines 360 (patched) <https://reviews.apache.org/r/63630/#comment270962> Is this required for something? I'd prefer to get rid of it if we're not using it. If we do need it for something, let's make it a `using` declaration. 3rdparty/stout/include/stout/lambda.hpp Lines 384 (patched) <https://reviews.apache.org/r/63630/#comment270961> `f == nullptr` - Michael Park On Dec. 4, 2017, 8 a.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63630/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 8 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-6972 > https://issues.apache.org/jira/browse/MESOS-6972 > > > Repository: mesos > > > Description > ------- > > `CallableOnce` class is similar to `std::function`, but allows it to be > called only once. Together with `partial` this provides foundation for > copy-less `defer`, `dispatch` and `Future`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/lambda.hpp > a61d97b69e7eebd057c94148d39c6e1fc3066017 > > > Diff: https://reviews.apache.org/r/63630/diff/4/ > > > Testing > ------- > > > Thanks, > > Dmitry Zhuk > >
