----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review192746 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.hpp Line 128 (original), 128 (patched) <https://reviews.apache.org/r/63915/#comment271003> Maybe we can consider making this `vector&&` as discussed in https://reviews.apache.org/r/63914/ - Michael Park On Nov. 21, 2017, 9:53 a.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63915/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 9:53 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-6972 > https://issues.apache.org/jira/browse/MESOS-6972 > > > Repository: mesos > > > Description > ------- > > Tasks can be moved into master's internal data structures from message > to save some cycles on copying the data. > > > Diffs > ----- > > src/master/master.hpp 0f8a2ac72c3484f911853c2994fc71a488d66d96 > src/master/master.cpp fadc78b2ca5d46b8cc12a794b428753aa79ac095 > > > Diff: https://reviews.apache.org/r/63915/diff/3/ > > > Testing > ------- > > make check > > Ran benchmark with `--enable-optimize --enable-lock-free-run-queue > --enable-lock-free-event-queue > --enable-last-in-first-out-fixed-size-semaphore` > `./mesos-tests.sh --benchmark > --gtest_filter=AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.*` > On 2608c0b8f62a9359d3d23e1724b6e91f316cfc76 (includes protobuf-3.5.0): > ``` > [ RUN ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 > Starting reregistration for all agents > Reregistered 2000 agents with a total of 100000 running tasks and 100000 > completed tasks in 16.202206916secs > [ OK ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 > (30065 ms) > [ RUN ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 > Starting reregistration for all agents > Reregistered 2000 agents with a total of 200000 running tasks and 0 completed > tasks in 30.509804836secs > [ OK ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 > (57145 ms) > [ RUN ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 > Starting reregistration for all agents > Reregistered 20000 agents with a total of 100000 running tasks and 0 > completed tasks in 22.581999748secs > [ OK ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 > (39629 ms) > ``` > > On this chain of patches: > ``` > [ RUN ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 > Starting reregistration for all agents > Reregistered 2000 agents with a total of 100000 running tasks and 100000 > completed tasks in 8.456615936secs > [ OK ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 > (22659 ms) > [ RUN ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 > Starting reregistration for all agents > Reregistered 2000 agents with a total of 200000 running tasks and 0 completed > tasks in 15.09102354secs > [ OK ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 > (43828 ms) > [ RUN ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 > Starting reregistration for all agents > Reregistered 20000 agents with a total of 100000 running tasks and 0 > completed tasks in 16.122729767secs > [ OK ] > AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 > (33182 ms) > ``` > > > Thanks, > > Dmitry Zhuk > >