-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63915/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 6:31 p.m.)
Review request for mesos, Benjamin Mahler and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972
Repository: mesos
Description
-------
Tasks can be moved into master's internal data structures from message
to save some cycles on copying the data.
Diffs (updated)
-----
src/master/master.hpp d42acae5a7d31dccf7073b57c3f2ddcfadea9e55
src/master/master.cpp 16cdde73b90b2e1514c6196850b8df75a3b6ff28
Diff: https://reviews.apache.org/r/63915/diff/4/
Changes: https://reviews.apache.org/r/63915/diff/3-4/
Testing
-------
make check
Ran benchmark with `--enable-optimize --enable-lock-free-run-queue
--enable-lock-free-event-queue --enable-last-in-first-out-fixed-size-semaphore`
`./mesos-tests.sh --benchmark
--gtest_filter=AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.*`
On 2608c0b8f62a9359d3d23e1724b6e91f316cfc76 (includes protobuf-3.5.0):
```
[ RUN ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
Starting reregistration for all agents
Reregistered 2000 agents with a total of 100000 running tasks and 100000
completed tasks in 16.202206916secs
[ OK ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
(30065 ms)
[ RUN ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
Starting reregistration for all agents
Reregistered 2000 agents with a total of 200000 running tasks and 0 completed
tasks in 30.509804836secs
[ OK ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
(57145 ms)
[ RUN ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
Starting reregistration for all agents
Reregistered 20000 agents with a total of 100000 running tasks and 0 completed
tasks in 22.581999748secs
[ OK ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
(39629 ms)
```
On this chain of patches:
```
[ RUN ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
Starting reregistration for all agents
Reregistered 2000 agents with a total of 100000 running tasks and 100000
completed tasks in 8.456615936secs
[ OK ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
(22659 ms)
[ RUN ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
Starting reregistration for all agents
Reregistered 2000 agents with a total of 200000 running tasks and 0 completed
tasks in 15.09102354secs
[ OK ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
(43828 ms)
[ RUN ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
Starting reregistration for all agents
Reregistered 20000 agents with a total of 100000 running tasks and 0 completed
tasks in 16.122729767secs
[ OK ]
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
(33182 ms)
```
Thanks,
Dmitry Zhuk
