> On Dec. 2, 2017, 8:49 a.m., Qian Zhang wrote: > > src/messages/flags.proto > > Lines 113 (patched) > > <https://reviews.apache.org/r/64265/diff/1/?file=1906399#file1906399line113> > > > > DurationInfo seems a too small time unit (nanosecond) which may not > > convenient for operator to specify, can we use a larger unit instead (like > > second)? > > Gilbert Song wrote: > was thinking the same thing. here is another option: > > `required double image_disk_watch_interval_seconds = 2;`
-1 to `double` + seconds: it produces non-precise machine value (i.e, we cannot precisely define 1ms with a floating double). - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64265/#review192620 ----------------------------------------------------------- On Dec. 2, 2017, 1:10 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64265/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2017, 1:10 a.m.) > > > Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-8294 > https://issues.apache.org/jira/browse/MESOS-8294 > > > Repository: mesos > > > Description > ------- > > Added a flag conversion protobuf message 'ImageGcConfig'. > > > Diffs > ----- > > src/messages/flags.proto 7ae9ef82cf9e918cac1eadc9f3ec0534ad4922b2 > > > Diff: https://reviews.apache.org/r/64265/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
