> On Dec. 2, 2017, 12:49 a.m., Qian Zhang wrote:
> > src/messages/flags.proto
> > Lines 113 (patched)
> > <https://reviews.apache.org/r/64265/diff/1/?file=1906399#file1906399line113>
> >
> > DurationInfo seems a too small time unit (nanosecond) which may not
> > convenient for operator to specify, can we use a larger unit instead (like
> > second)?
>
> Gilbert Song wrote:
> was thinking the same thing. here is another option:
>
> `required double image_disk_watch_interval_seconds = 2;`
>
> Zhitao Li wrote:
> -1 to `double` + seconds: it produces non-precise machine value (i.e, we
> cannot precisely define 1ms with a floating double).
Chatted with @Vinod and @Zhitao offline. We have 3 options:
1. Introduce a new protobuf `DurationValue`: (tech debt)
```
message DurationValue {
enum Unit {
SECONDS = 0;
MINUTES = 1;
....
}
requried Unit unit = 1;
required int64 value = 2;
}
```
But this would related to many other duration definition. They belong to tech
debts that should be addressed together.
2. Define it as a `string` and leverage the `Duration::Paser()` to parse it.
(not compatible with some other language library standard, eg., GO language
library).
3. Use `required double image_disk_watch_interval_seconds = 2;` (not accurate)
After a second thought, I decide to still use `nanoseconds` as it is accurate
enough. we can deprecate it once we have opeiton #1 in the future.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64265/#review192620
-----------------------------------------------------------
On Dec. 1, 2017, 5:10 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64265/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 5:10 p.m.)
>
>
> Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li.
>
>
> Bugs: MESOS-8294
> https://issues.apache.org/jira/browse/MESOS-8294
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a flag conversion protobuf message 'ImageGcConfig'.
>
>
> Diffs
> -----
>
> src/messages/flags.proto 7ae9ef82cf9e918cac1eadc9f3ec0534ad4922b2
>
>
> Diff: https://reviews.apache.org/r/64265/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
