----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review193010 -----------------------------------------------------------
src/status_update_manager/status_update_manager_process.hpp Lines 808-810 (patched) <https://reviews.apache.org/r/64095/#comment271481> We should really only do something like this in test code, if ever (a `.get()` without a CHECK or `if` guard). Adding the CHECK will get us a stack trace if things go wrong. Instead, here let's do: ``` Try<UUID> statusUuid = UUID::fromBytes(update.status().status_uuid()); CHECK_SOME(statusUuid); if (acknowledged.contains(statusUuid.get())) { ``` Here and elsewhere. - Greg Mann On Dec. 2, 2017, 2:44 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64095/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2017, 2:44 a.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8197 > https://issues.apache.org/jira/browse/MESOS-8197 > > > Repository: mesos > > > Description > ------- > > This actor handles the checkpointing, recovery, and retry of status > updates. > > It will initially be used by the offer operations status update > manager, but it was designed and implemented so that it can replace > the current implementation of the task status update manager. > > > Diffs > ----- > > src/status_update_manager/status_update_manager_process.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64095/diff/7/ > > > Testing > ------- > > Added new tests at the end of the chain. They passed 5000 times on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
