----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review193204 -----------------------------------------------------------
src/status_update_manager/status_update_manager_process.hpp Lines 117 (patched) <https://reviews.apache.org/r/64095/#comment271752> Nit: let's add a `that` for consistency. I can fix while committing. src/status_update_manager/status_update_manager_process.hpp Lines 121 (patched) <https://reviews.apache.org/r/64095/#comment271753> Nit: backticks. I'll fix while committing. src/status_update_manager/status_update_manager_process.hpp Lines 182 (patched) <https://reviews.apache.org/r/64095/#comment271756> Let's get rid of "framework=" here and below. Will fix while committing. src/status_update_manager/status_update_manager_process.hpp Lines 361-371 (patched) <https://reviews.apache.org/r/64095/#comment271759> Nit: Too many newlines between methods. I'll fix while committing. src/status_update_manager/status_update_manager_process.hpp Lines 377 (patched) <https://reviews.apache.org/r/64095/#comment271760> Nit: Let's iterate with a reference here. Will fix while committing. src/status_update_manager/status_update_manager_process.hpp Lines 509 (patched) <https://reviews.apache.org/r/64095/#comment271763> Nit: we can omit this comment. Will fix while committing. src/status_update_manager/status_update_manager_process.hpp Lines 805 (patched) <https://reviews.apache.org/r/64095/#comment271767> Using underscores like this doesn't really follow our style guide. Let's follow up with a patch later to fix this style throughout the class. - Greg Mann On Dec. 7, 2017, 1:22 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64095/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 1:22 a.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8197 > https://issues.apache.org/jira/browse/MESOS-8197 > > > Repository: mesos > > > Description > ------- > > This actor handles the checkpointing, recovery, and retry of status > updates. > > It will initially be used by the offer operations status update > manager, but it was designed and implemented so that it can replace > the current implementation of the task status update manager. > > > Diffs > ----- > > src/slave/constants.hpp 2d07bce299e63b8492a5ecb08b29508a671bc14c > src/status_update_manager/status_update_manager_process.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64095/diff/10/ > > > Testing > ------- > > Added new tests at the end of the chain. They passed 5000 times on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
