----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64428/#review193184 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 6675-6684 (original) <https://reviews.apache.org/r/64428/#comment271721> It looks like we still do all of these (via move) except `tasks`. I would've expected to see these still here but turned into moves. What was the motivation for the new pattern? src/master/master.cpp Lines 6690 (patched) <https://reviews.apache.org/r/64428/#comment271720> Shouldn't need `std::cref` here. - Michael Park On Dec. 7, 2017, 12:46 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64428/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 12:46 p.m.) > > > Review request for mesos, Dmitry Zhuk and Michael Park. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249 > src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0 > > > Diff: https://reviews.apache.org/r/64428/diff/3/ > > > Testing > ------- > > About a 10-20% improvement. > > Before: > Reregistered 2000 agents with a total of 100000 running tasks and 100000 > completed tasks in 2.977767303secs > Reregistered 2000 agents with a total of 200000 running tasks and 0 completed > tasks in 5.642229947secs > Reregistered 20000 agents with a total of 100000 running tasks and 0 > completed tasks in 6.966318315secs > > After: > Reregistered 2000 agents with a total of 100000 running tasks and 100000 > completed tasks in 2.591612374secs > Reregistered 2000 agents with a total of 200000 running tasks and 0 completed > tasks in 4.52633125secs > Reregistered 20000 agents with a total of 100000 running tasks and 0 > completed tasks in 6.449984263secs > > > Thanks, > > Benjamin Mahler > >
