----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64428/#review193163 -----------------------------------------------------------
src/master/master.cpp Line 9480 (original), 9495 (patched) <https://reviews.apache.org/r/64428/#comment271679> Should I just take a copy here to avoid forcing the caller to provide an rvalue reference? Much like we did in the `Slave` struct. - Benjamin Mahler On Dec. 7, 2017, 8:32 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64428/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 8:32 p.m.) > > > Review request for mesos, Dmitry Zhuk and Michael Park. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249 > src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0 > > > Diff: https://reviews.apache.org/r/64428/diff/1/ > > > Testing > ------- > > About a 15% improvement. > > Before: > Reregistered 2000 agents with a total of 100000 running tasks and 100000 > completed tasks in 2.977767303secs > Reregistered 2000 agents with a total of 200000 running tasks and 0 completed > tasks in 5.642229947secs > Reregistered 20000 agents with a total of 100000 running tasks and 0 > completed tasks in 6.966318315secs > > After: > Reregistered 2000 agents with a total of 100000 running tasks and 100000 > completed tasks in 2.623647005secs > Reregistered 2000 agents with a total of 200000 running tasks and 0 completed > tasks in 5.032204158secs > Reregistered 20000 agents with a total of 100000 running tasks and 0 > completed tasks in 6.187945743secs > > > Thanks, > > Benjamin Mahler > >
