> On Nov. 16, 2017, 6:08 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/uri.hpp > > Lines 19 (patched) > > <https://reviews.apache.org/r/60622/diff/6/?file=1864343#file1864343line19> > > > > This looks like an accidental include?
Yup, good catch, thanks. > On Nov. 16, 2017, 6:08 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/uri.hpp > > Lines 31 (patched) > > <https://reviews.apache.org/r/60622/diff/6/?file=1864343#file1864343line31> > > > > This should be `#ifdef __WINDOWS__`, right? Yup. And line 34 should have included `// __WINDOWS__` at the end. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review191203 ----------------------------------------------------------- On Nov. 6, 2017, 6:08 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60622/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 6:08 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li > Li, and Michael Park. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Added new stout function: path::from_uri, which converts to a filepath > from a URI. > > Also added uri::from_path, which generates a URI from a file path. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > 3rdparty/stout/include/Makefile.am bdd3e9908ebfc682458a3babc34cbee36ad3f751 > 3rdparty/stout/include/stout/path.hpp > 6ee3a44cd6a878fe383aa68df40b82857b93d0b4 > 3rdparty/stout/include/stout/uri.hpp PRE-CREATION > 3rdparty/stout/tests/CMakeLists.txt > 6e5773f1e03671de7ac007caf49edd0f1cd7aedd > 3rdparty/stout/tests/path_tests.cpp > f8c14d5aefe0b49adb778da784143a328c96183d > 3rdparty/stout/tests/uri_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60622/diff/6/ > > > Testing > ------- > > See upstream > > > Thanks, > > Jeff Coffler > >