----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64434/#review193233 -----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed. Reviews applied: `['64434']` Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64434 Relevant logs: - [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64434/logs/libprocess-tests-stdout.log): ``` C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" (16718 ms) [ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (16662 ms) [----------] 4 tests from SSLVerifyIPAdd/SSLTest (34711 ms total) [----------] Global test environment tear-down [==========] 223 tests from 35 test cases ran. (263501 ms total) [ PASSED ] 209 tests. [ FAILED ] 14 tests, listed below: [ FAILED ] SSLTest.SSLSocket [ FAILED ] SSLTest.NonSSLSocket [ FAILED ] SSLTest.NoVerifyBadCA [ FAILED ] SSLTest.RequireBadCA [ FAILED ] SSLTest.VerifyBadCA [ FAILED ] SSLTest.VerifyCertificate [ FAILED ] SSLTest.ProtocolMismatch [ FAILED ] SSLTest.ECDHESupport [ FAILED ] SSLTest.ValidDowngrade [ FAILED ] SSLTest.NoValidDowngrade [ FAILED ] SSLTest.ValidDowngradeEachProtocol [ FAILED ] SSLTest.NoValidDowngradeEachProtocol [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" 14 FAILED TESTS YOU HAVE 19 DISABLED TESTS ``` - [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64434/logs/libprocess-tests-stderr.log): ``` I1208 09:42:25.940520 6680 process.cpp:887] Failed to accept socket: future discarded I1208 09:42:26.150099 7552 process.cpp:887] Failed to accept socket: future discarded I1208 09:42:26.581262 7836 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 09:42:26.581262 7836 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 09:42:26.582262 7836 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\LpXkTG\cert.pem I1208 09:42:26.582262 7836 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\LpXkTG I1208 09:42:27.453328 7836 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 09:42:27.453328 7836 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension. I1208 09:42:27.453328 7836 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 09:42:27.464329 7836 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\wvkeIO\cert.pem I1208 09:42:27.464329 7836 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\wvkeIO I1208 09:42:28.207820 7836 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> I1208 09:42:28.207820 7836 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 09:42:28.208822 7836 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 09:42:28.208822 7836 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\xZtiAZ\cert.pem I1208 09:42:44.880146 7836 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> I1208 09:42:44.880146 7836 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 09:42:44.880146 7836 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension. I1208 09:42:44.881145 7836 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 09:42:44.881145 7836 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\iK4hdm\cert.pem I1208 09:43:01.028960 868 process.cpp:887] Failed to accept socket: future discarded ``` - Mesos Reviewbot Windows On Dec. 7, 2017, 8:05 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64434/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 8:05 p.m.) > > > Review request for mesos, Akash Gupta and Joseph Wu. > > > Bugs: MESOS-5939 > https://issues.apache.org/jira/browse/MESOS-5939 > > > Repository: mesos > > > Description > ------- > > Removed the use of CRT runtime API `::_stat`, and instead implemented > with `get_handle_[no_]follow()` plus `GetFileSizeEx` to correctly obtain > the size of a file with long-path and symlink-aware semantics. > > This resolves MESOS-5939 and so enables `OsTest.SYMLINK_Size`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/stat.hpp > 2ba6969a78eb6ed7007a3d404d5179b143790480 > 3rdparty/stout/tests/os_tests.cpp 93a23a800e5301abdc71c8b61022cc9baabf12c2 > > > Diff: https://reviews.apache.org/r/64434/diff/2/ > > > Testing > ------- > > [==========] Running 7 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 7 tests from OsTest > [ RUN ] OsTest.TrivialEnvironment > [ OK ] OsTest.TrivialEnvironment (5 ms) > [ RUN ] OsTest.Argv > [ OK ] OsTest.Argv (1 ms) > [ RUN ] OsTest.System > 'invalid.command' is not recognized as an internal or external command, > operable program or batch file. > [ OK ] OsTest.System (277 ms) > [ RUN ] OsTest.SYMLINK_Size > [ OK ] OsTest.SYMLINK_Size (7 ms) > [ RUN ] OsTest.BootId > [ OK ] OsTest.BootId (4 ms) > [ RUN ] OsTest.TrivialUser > [ OK ] OsTest.TrivialUser (4 ms) > [ RUN ] OsTest.SYMLINK_Realpath > [ OK ] OsTest.SYMLINK_Realpath (7 ms) > [----------] 7 tests from OsTest (318 ms total) > > [----------] Global test environment tear-down > [==========] 7 tests from 1 test case ran. (321 ms total) > [ PASSED ] 7 tests. > > YOU HAVE 3 DISABLED TESTS > > > Thanks, > > Andrew Schwartzmeyer > >