-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64434/
-----------------------------------------------------------
(Updated Dec. 11, 2017, 1:37 p.m.)
Review request for mesos, Akash Gupta and Joseph Wu.
Changes
-------
Style change.
Bugs: MESOS-5939
https://issues.apache.org/jira/browse/MESOS-5939
Repository: mesos
Description
-------
Removed the use of CRT runtime API `::_stat`, and instead implemented
with `get_handle_[no_]follow()` plus `GetFileSizeEx` to correctly obtain
the size of a file with long-path and symlink-aware semantics.
This resolves MESOS-5939 and so enables `OsTest.SYMLINK_Size`.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/stat.hpp
2ba6969a78eb6ed7007a3d404d5179b143790480
3rdparty/stout/tests/os_tests.cpp 93a23a800e5301abdc71c8b61022cc9baabf12c2
Diff: https://reviews.apache.org/r/64434/diff/3/
Changes: https://reviews.apache.org/r/64434/diff/2-3/
Testing
-------
[==========] Running 7 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 7 tests from OsTest
[ RUN ] OsTest.TrivialEnvironment
[ OK ] OsTest.TrivialEnvironment (5 ms)
[ RUN ] OsTest.Argv
[ OK ] OsTest.Argv (1 ms)
[ RUN ] OsTest.System
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
[ OK ] OsTest.System (277 ms)
[ RUN ] OsTest.SYMLINK_Size
[ OK ] OsTest.SYMLINK_Size (7 ms)
[ RUN ] OsTest.BootId
[ OK ] OsTest.BootId (4 ms)
[ RUN ] OsTest.TrivialUser
[ OK ] OsTest.TrivialUser (4 ms)
[ RUN ] OsTest.SYMLINK_Realpath
[ OK ] OsTest.SYMLINK_Realpath (7 ms)
[----------] 7 tests from OsTest (318 ms total)
[----------] Global test environment tear-down
[==========] 7 tests from 1 test case ran. (321 ms total)
[ PASSED ] 7 tests.
YOU HAVE 3 DISABLED TESTS
Thanks,
Andrew Schwartzmeyer
