> On Dec. 8, 2017, 5:47 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > > Lines 354 (patched) > > <https://reviews.apache.org/r/64461/diff/1/?file=1911723#file1911723line357> > > > > Does this flag exist on older versions of Windows? You might need a > > `#ifndef X #define X Y #endif` to get this to compile > > Andrew Schwartzmeyer wrote: > The flag is in the SDK, so it builds correctly as long as Visual Studio > is up-to-date. It just fails at runtime on older systems.
Confirmed. If the Visual Studio Windows 10 SDK >= 15063, this will build regardless of the Windows version. With it built, this will work at runtime on the older systems (pre build 15063). Example: CloudBase's CI (the ReviewBot) was building fine, but with a `mesos-tests` unit test failing at runtime. The symlink stout-tests were appropriately skipped because `fs::symlink` failed, but that's not great because `mesos-tests` require them anyway, and don't filter. Mesosphere's CI was failing at compile-time, but that should be resolvable by updating the SDK. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64461/#review193302 ----------------------------------------------------------- On Dec. 8, 2017, 1:18 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64461/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2017, 1:18 p.m.) > > > Review request for mesos, Akash Gupta, Alexander Rukletsov, Greg Mann, and > Joseph Wu. > > > Bugs: MESOS-8307 > https://issues.apache.org/jira/browse/MESOS-8307 > > > Repository: mesos > > > Description > ------- > > Some users are regrettably stuck on versions of Windows before this > feature was added. If the `ALLOW_UNPRIVILEGED` flag is unsupported, the > creation of the symlink will fail with `ERROR_INVALID_PARAMETER`. In > this case, we try again without the flag (which will require > administrative privileges, and so need to be guarded by a mutex) for > these older systems. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > 158f44550327c63fb416052ad9978b55e4efe36b > > > Diff: https://reviews.apache.org/r/64461/diff/1/ > > > Testing > ------- > > Still works on Windows 10 Fall Creator's Update, needs to be tested to prove > working on legacy systems. > > > Thanks, > > Andrew Schwartzmeyer > >
