> On Dec. 14, 2017, 11:46 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > > Lines 361 (patched) > > <https://reviews.apache.org/r/64461/diff/2/?file=1917316#file1917316line367> > > > > Maybe, this control flow would be clearer: > > > > ```C > > if (link(...)) { > > return Nothing(); > > } > > > > if (GetLastError() == INVALID) { > > if (link(flags))) { > > return Nothing(); > > } > > } > > > > return WindowsError(); > > ```
That is so much better, thank you. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64461/#review193832 ----------------------------------------------------------- On Dec. 14, 2017, 11:35 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64461/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 11:35 a.m.) > > > Review request for mesos, Akash Gupta, Alexander Rukletsov, Greg Mann, and > Joseph Wu. > > > Bugs: MESOS-8307 > https://issues.apache.org/jira/browse/MESOS-8307 > > > Repository: mesos > > > Description > ------- > > Some users are regrettably stuck on versions of Windows before this > feature was added. If the `ALLOW_UNPRIVILEGED` flag is unsupported, the > creation of the symlink will fail with `ERROR_INVALID_PARAMETER`. In > this case, we try again without the flag (which will require > administrative privileges, and so need to be guarded by a mutex) for > these older systems. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > 158f44550327c63fb416052ad9978b55e4efe36b > > > Diff: https://reviews.apache.org/r/64461/diff/2/ > > > Testing > ------- > > ~Still works on Windows 10 Fall Creator's Update, needs to be tested to prove > working on legacy systems.~ > > Tested on Windows Server 2016. _Other, unrelated stout-tests fail on the old > systems because of different reasons regarding username expansion._ Symlinks > work again. > > > Thanks, > > Andrew Schwartzmeyer > >
