----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64515/#review193690 -----------------------------------------------------------
src/master/master.cpp Line 3876 (original), 3881 (patched) <https://reviews.apache.org/r/64515/#comment272292> You can now log the `SlaveID` here. src/master/master.cpp Lines 3905 (patched) <https://reviews.apache.org/r/64515/#comment272313> So what are the semantics for dynamic resources? If this new ACL semantics is expressing that resources in role `Foo` may only be provided on agents which principal `Bar`, it doesn't seem correct that we would allow dynamic reservations to violate that. src/master/master.cpp Lines 3919 (patched) <https://reviews.apache.org/r/64515/#comment272295> Although this is similar to code used elsewhere, you can also just do: ``` return std::find(results.begin(), results.end(), false) == std::end(results); ``` - James Peach On Dec. 12, 2017, 12:30 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64515/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2017, 12:30 a.m.) > > > Review request for mesos, Alexander Rojas and James Peach. > > > Bugs: MESOS-8306 > https://issues.apache.org/jira/browse/MESOS-8306 > > > Repository: mesos > > > Description > ------- > > Used `reserve_resources` ACL for static reservations. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 40a1425ca51c5bb70f7af2e17d605f2125dcb4cb > src/master/master.hpp 232cc3758f240db626c4fdaf852163fa48af4dd7 > src/master/master.cpp b10d0341276090bfa70aaa4fd6317a560e3334ea > src/tests/master_authorization_tests.cpp > 676543a5ad1bb5d47011fc2a8b05dfaaeef18c64 > > > Diff: https://reviews.apache.org/r/64515/diff/1/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
