> On Jan. 9, 2018, 8:45 a.m., James Peach wrote: > > What do you think about testing the re-registration case? There's no > > coverage here, but equally, it would be annoying to duplicate all these > > tests for re-registration ...
Two other tests `AuthorizedToRegisterAndReregisterAgent` and `UnauthorizedToReregisterAgent` have covered the reregister case (both success and failure), even though the condition in these test differ slightly in that they don't include roles, I feel that they share the common logic around the handling the authorization success and failure of reregistering agents so they are adequate? > On Jan. 9, 2018, 8:45 a.m., James Peach wrote: > > src/tests/master_authorization_tests.cpp > > Lines 2516 (patched) > > <https://reviews.apache.org/r/64515/diff/3/?file=1929962#file1929962line2516> > > > > What happens with the "*" role? Is that covered by > > "AuthorizedToRegisterNoStaticReservations"? Yes. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64515/#review195042 ----------------------------------------------------------- On Jan. 10, 2018, 2:22 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64515/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 2:22 p.m.) > > > Review request for mesos, Alexander Rojas and James Peach. > > > Bugs: MESOS-8306 > https://issues.apache.org/jira/browse/MESOS-8306 > > > Repository: mesos > > > Description > ------- > > Used `reserve_resources` ACL for static reservations. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > d869820491f1b81f81e1157493aa73e32735b9c3 > src/master/master.hpp 5e6ba53c075174a1e514a395ceb17c26201ec470 > src/master/master.cpp 6fc5de89e54ba0b9ae2c4fb475be9878910820d3 > src/tests/master_authorization_tests.cpp > 676543a5ad1bb5d47011fc2a8b05dfaaeef18c64 > > > Diff: https://reviews.apache.org/r/64515/diff/4/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
