----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review193897 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/containerizer.hpp Lines 54-55 (patched) <https://reviews.apache.org/r/63953/#comment272564> Please backtick class values. Also, let's explain why we do it (to avoid polluting the agent log with DEBUG container related information, because DEBUG containers can be started in a periodic manner). src/slave/containerizer/mesos/containerizer.cpp Line 2335 (original), 2338-2339 (patched) <https://reviews.apache.org/r/63953/#comment272565> Ups - Alexander Rukletsov On Dec. 13, 2017, 7:47 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63953/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 7:47 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-7361 > https://issues.apache.org/jira/browse/MESOS-7361 > > > Repository: mesos > > > Description > ------- > > This change adjusts log level based on the container class. > If the class is `DEBUG` we print the log entry at a verbose > level 1, otherwise we print it at the `INFO` level. > > We use the added macro in mesos containerizer so that COMMAND > checks cause less INFO logs (15 lines instead of 26 before). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 965e183bb5c54f31d90e910edd35313ab380cea9 > src/slave/containerizer/mesos/containerizer.cpp > 7ab0b07f689f872573ca458ae47cd6426ebc0365 > > > Diff: https://reviews.apache.org/r/63953/diff/8/ > > > Testing > ------- > > Started a Mesos cluster and used `mesos-execute` with this task group to > check that the behaviour after this patch is the one expected: > > ``` > { > "tasks": [ > { > "name": "Name of the task", > "task_id": { > "value": "task-group" > }, > "agent_id": { > "value": "" > }, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.01 > } > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 2 > } > } > ], > "command": { > "value": "sleep 1000" > }, > "check": { > "type": "COMMAND", > "command": { > "command": { > "value": "echo \"Bonjour\"" > }, > "uris": [] > } > } > } > ] > } > ``` > > And: > ``` > $ nice make check > ``` > > > Thanks, > > Armand Grillet > >
