----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review193267 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp Line 356 (original), 361-368 (patched) <https://reviews.apache.org/r/63953/#comment271816> Let's pull this is a separate patch. src/slave/containerizer/mesos/containerizer.hpp Lines 364-365 (patched) <https://reviews.apache.org/r/63953/#comment271811> There is no option here, hence no need for the comment. src/slave/containerizer/mesos/containerizer.cpp Lines 1630-1632 (original), 1632-1633 (patched) <https://reviews.apache.org/r/63953/#comment271817> This is not related to logging and hence belongs to the separate patch you will create for `containerClass()` src/slave/containerizer/mesos/containerizer.cpp Lines 1649-1650 (original), 1650 (patched) <https://reviews.apache.org/r/63953/#comment271818> Ditto. src/slave/containerizer/mesos/containerizer.cpp Lines 1702-1703 (original), 1702 (patched) <https://reviews.apache.org/r/63953/#comment271819> Ditto. src/slave/containerizer/mesos/containerizer.cpp Lines 2863 (patched) <https://reviews.apache.org/r/63953/#comment271814> Do you need to use a FQN here? - Alexander Rukletsov On Dec. 6, 2017, 2:47 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63953/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 2:47 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-7361 > https://issues.apache.org/jira/browse/MESOS-7361 > > > Repository: mesos > > > Description > ------- > > This change adjusts log level based on the container class. > If the class is `DEBUG` we print the log entry at a verbose > level 1, otherwise we print it at the `INFO` level. > > We use the added macro in mesos containerizer so that COMMAND > checks cause less INFO logs (15 lines instead of 26 before). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > e2739e017cb8dda37d94ad809ca1bd461f308bfb > src/slave/containerizer/mesos/containerizer.cpp > 7f3b86d87cf82429c2627d4a32eb0d5adbcc3f29 > > > Diff: https://reviews.apache.org/r/63953/diff/6/ > > > Testing > ------- > > Started a Mesos cluster and used `mesos-execute` with this task group to > check that the behaviour after this patch is the one expected: > > ``` > { > "tasks": [ > { > "name": "Name of the task", > "task_id": { > "value": "task-group" > }, > "agent_id": { > "value": "" > }, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.01 > } > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 2 > } > } > ], > "command": { > "value": "sleep 1000" > }, > "check": { > "type": "COMMAND", > "command": { > "command": { > "value": "echo \"Bonjour\"" > }, > "uris": [] > } > } > } > ] > } > ``` > > And: > ``` > $ nice make check > ``` > > > Thanks, > > Armand Grillet > >
