----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/ -----------------------------------------------------------
(Updated Dec. 20, 2017, 4:27 p.m.) Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone. Summary (updated) ----------------- WIP: Ensured executor adapter propagates error and shutdown messages. Repository: mesos Description ------- Prior to this patch, if an error or shutdown occurred during subscription / registration with the agent, it was not propagated back to the executor if the v0_v1 executor adapter was used. This happened because the adapter did not call the `connected` callback until after successful registration and hence the executor did not even try to send the `SUBSCRIBE` call, without which the adapter did not send any events to the executor. A fix is to call the `connected` callback if an error occurred or shutdown even arrived before the executor had subscribed. Diffs ----- src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb Diff: https://reviews.apache.org/r/64070/diff/1/ Testing ------- Thanks, Alexander Rukletsov
