----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/#review195131 -----------------------------------------------------------
Fix it, then Ship it! docs/networking.md Lines 118-122 (patched) <https://reviews.apache.org/r/63861/#comment274274> Can you please mention that other network modes than `NAT` and `USER` are not supported in Mesos? docs/networking.md Line 118 (original), 121-123 (patched) <https://reviews.apache.org/r/63861/#comment274273> I'm not sure this is true with our proto having a default value. Can you please verify that? - Alexander Rukletsov On Jan. 10, 2018, 1:42 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63861/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 1:42 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, Jie Yu, John Kordich, and Michael Park. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > The networking docs now describe how the Docker network modes in the > `Network` enum work on Windows, since the enum only has Linux network > modes. > > > Diffs > ----- > > docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983 > > > Diff: https://reviews.apache.org/r/63861/diff/8/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
