----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195226 -----------------------------------------------------------
PASS: Mesos patch 65072 was successfully built and tested. Reviews applied: `['65093', '65095', '65096', '65072']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65072 - Mesos Reviewbot Windows On Jan. 11, 2018, 2:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65072/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2018, 2:53 p.m.) > > > Review request for mesos, Gaston Kleiman and Greg Mann. > > > Bugs: MESOS-8422 > https://issues.apache.org/jira/browse/MESOS-8422 > > > Repository: mesos > > > Description > ------- > > An offer operation can be become terminal between any previously > received non-terminal offer operation status update and receiving an > `UpdateSlaveMessage` (e.g., if the agent failed over, or when the > agent was partitioned from the master). > > The master will in its offer operations status handler attempt > to apply operations which became terminal since the last update. At > the same time, the total resources in an `UpdateSlaveMessage` would > already contain the result of applying the operation, and we need to > prevent the master from attempting to apply the same operation twice. > > This patch updates the master handler for `UpdateSlaveMessage` to > transition pending operations which are reported as terminal. For that > we add a new parameter to `updateOperation` to selectively disable > updating of resource state as needed in when called from the > `UpdateSlaveMessage` handler. > > > Diffs > ----- > > src/master/master.cpp 7ed15e4ba2a31c5fe4b8571f645cdca69a3e82f4 > > > Diff: https://reviews.apache.org/r/65072/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
