----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195302 -----------------------------------------------------------
FAIL: mesos-java failed to build. Reviews applied: `['65093', '65095', '65096', '65072']` Failed command: `cmake.exe --build . --target mesos-java` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65072 Relevant logs: - [mesos-java-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65072/logs/mesos-java-build-cmake-stdout.log): ``` d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3091): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] "D:\DCOS\mesos\src\java\mesos-java.vcxproj" (default target) (1) -> "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (19) -> (ClCompile target) -> D:\DCOS\mesos\mesos\3rdparty\libprocess\src\metrics\metrics.cpp(261): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_7d0081acgl': No space left on device [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj] D:\DCOS\mesos\mesos\3rdparty\libprocess\src\http.cpp(2572): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp_CL_49067b72gl': No space left on device [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj] 199 Warning(s) 2 Error(s) Time Elapsed 00:18:06.58 ``` - [mesos-java-build-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65072/logs/mesos-java-build-CMakeOutput.log): ``` Creating directory "cmTC_e1a16.dir\Debug\". Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\". Creating directory "cmTC_e1a16.dir\Debug\cmTC_e1a16.tlog\". InitializeBuildStatus: Creating "cmTC_e1a16.dir\Debug\cmTC_e1a16.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified. ClCompile: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_e1a16.dir\Debug\" /Fd"cmTC_e1a16.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64 Copyright (C) Microsoft Corporation. All rights reserved. cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_e1a16.dir\Debug\" /Fd"cmTC_e1a16.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx src.cxx Link: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e1a16.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e1a16.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e1a16.lib" /MACHINE:X64 /machine:x64 cmTC_e1a16.dir\Debug\src.obj cmTC_e1a16.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e1a16.exe FinalizeBuildStatus: Deleting file "cmTC_e1a16.dir\Debug\cmTC_e1a16.tlog\unsuccessfulbuild". Touching "cmTC_e1a16.dir\Debug\cmTC_e1a16.tlog\cmTC_e1a16.lastbuildstate". Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_e1a16.vcxproj" (default targets). Build succeeded. 0 Warning(s) 0 Error(s) Time Elapsed 00:00:01.19 Source file was: int main() { return 0; } ``` - [mesos-java-build-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65072/logs/mesos-java-build-CMakeError.log): ``` PrepareForBuild: Creating directory "cmTC_81511.dir\Debug\". Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\". Creating directory "cmTC_81511.dir\Debug\cmTC_81511.tlog\". InitializeBuildStatus: Creating "cmTC_81511.dir\Debug\cmTC_81511.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified. ClCompile: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_81511.dir\Debug\" /Fd"cmTC_81511.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64 Copyright (C) Microsoft Corporation. All rights reserved. cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_81511.dir\Debug\" /Fd"cmTC_81511.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c CheckIncludeFile.c D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_81511.vcxproj] Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_81511.vcxproj" (default targets) -- FAILED. Build FAILED. "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_81511.vcxproj" (default target) (1) -> (ClCompile target) -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_81511.vcxproj] 0 Warning(s) 1 Error(s) Time Elapsed 00:00:00.58 ``` - Mesos Reviewbot Windows On Jan. 12, 2018, 10:57 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65072/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 10:57 a.m.) > > > Review request for mesos, Gaston Kleiman and Greg Mann. > > > Bugs: MESOS-8422 > https://issues.apache.org/jira/browse/MESOS-8422 > > > Repository: mesos > > > Description > ------- > > An offer operation can be become terminal between any previously > received non-terminal offer operation status update and receiving an > `UpdateSlaveMessage` (e.g., if the agent failed over, or when the > agent was partitioned from the master). > > The master will in its offer operations status handler attempt > to apply operations which became terminal since the last update. At > the same time, the total resources in an `UpdateSlaveMessage` would > already contain the result of applying the operation, and we need to > prevent the master from attempting to apply the same operation twice. > > This patch updates the master handler for `UpdateSlaveMessage` to > transition pending operations which are reported as terminal without > also updating the resources on the agent as any update would already > be reflected in the new total from the `UpdateSlaveMessage. > > > Diffs > ----- > > src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab > > > Diff: https://reviews.apache.org/r/65072/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
