-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65144/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Bugs: MESOS-8225
https://issues.apache.org/jira/browse/MESOS-8225
Repository: mesos
Description
-------
Because `os::which` still lived in `posix/os.hpp`, it was refactored
into its own `os/which.hpp` (which the respective `os/posix/which.hpp`
and `os/windows/which.hpp`. Consumers of this will need additionally
include the new header, instead of just `os.hpp`.
The differences in implementation from POSIX to Windows are:
* Split the `PATH` on `;` not `:`.
* Also loop over `PATHEXT` because executables on Windows end with one
of a set of extensions.
* Removed the permissions check because it is not applicable on
Windows (instead, an executable ends with an extension in `PATHEXT`,
see above).
Diffs
-----
3rdparty/stout/include/Makefile.am e5f11048af4ced8e8312d5c77fc3dde94f8e7012
3rdparty/stout/include/stout/os/posix/which.hpp PRE-CREATION
3rdparty/stout/include/stout/os/which.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/which.hpp PRE-CREATION
3rdparty/stout/include/stout/posix/os.hpp
7427bd792368fbacafb23593dfb9213618fdcddf
3rdparty/stout/tests/os_tests.cpp de4107718cfa45f3275693a7dd59b2f52b0ced7d
Diff: https://reviews.apache.org/r/65144/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
