----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65153/#review195397 -----------------------------------------------------------
PASS: Mesos patch 65153 was successfully built and tested. Reviews applied: `['65153']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65153 - Mesos Reviewbot Windows On Jan. 14, 2018, 5:05 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65153/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2018, 5:05 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-8440 > https://issues.apache.org/jira/browse/MESOS-8440 > > > Repository: mesos > > > Description > ------- > > At recovery time, the containerizer sends only the executor resources, > but ports are typically allocated against tasks. This means that we > don't know about the complete set of container resources until the > containerizer makes the subsequent `update()` call. If we perform a > container ports check between the two calls, we can erroneously kill > the container because we believe it to have no allocated ports. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.cpp > 7d5ff4f6d917352abd9ac0158a56eae7911aff0f > > > Diff: https://reviews.apache.org/r/65153/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
