----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65153/#review195442 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 392 (patched) <https://reviews.apache.org/r/65153/#comment274617> s/th/the/ - Qian Zhang On Jan. 14, 2018, 1:05 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65153/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2018, 1:05 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-8440 > https://issues.apache.org/jira/browse/MESOS-8440 > > > Repository: mesos > > > Description > ------- > > At recovery time, the containerizer sends only the executor resources, > but ports are typically allocated against tasks. This means that we > don't know about the complete set of container resources until the > containerizer makes the subsequent `update()` call. If we perform a > container ports check between the two calls, we can erroneously kill > the container because we believe it to have no allocated ports. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.cpp > 7d5ff4f6d917352abd9ac0158a56eae7911aff0f > > > Diff: https://reviews.apache.org/r/65153/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
