----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65125/#review195413 -----------------------------------------------------------
src/tests/resource_provider_manager_tests.cpp Lines 130 (patched) <https://reviews.apache.org/r/65125/#comment274587> We still have a lot of repeated code creating these test endpoint detectors. I'd suggest moving this into e.g., `tests/mesos.hpp`. This would allow us to remove more duplication. - Benjamin Bannier On Jan. 12, 2018, 3:15 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65125/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 3:15 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8445 > https://issues.apache.org/jira/browse/MESOS-8445 > > > Repository: mesos > > > Description > ------- > > Added a helper function for resource provider tests. > > > Diffs > ----- > > src/tests/resource_provider_manager_tests.cpp > d80823c47963e969113dae3623b18b7639c890fc > > > Diff: https://reviews.apache.org/r/65125/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
