----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65125/#review195551 -----------------------------------------------------------
Fix it, then Ship it! src/tests/mesos.hpp Lines 3110 (patched) <https://reviews.apache.org/r/65125/#comment274786> Let's return an `Owned` here. - Benjamin Bannier On Jan. 15, 2018, 3:50 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65125/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2018, 3:50 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8445 > https://issues.apache.org/jira/browse/MESOS-8445 > > > Repository: mesos > > > Description > ------- > > Added a helper function for resource provider tests. > > > Diffs > ----- > > src/tests/api_tests.cpp fb45879310faf7edc7d101be206d49de89819c18 > src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 > src/tests/resource_provider_manager_tests.cpp > d80823c47963e969113dae3623b18b7639c890fc > src/tests/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86 > > > Diff: https://reviews.apache.org/r/65125/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
