----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195544 -----------------------------------------------------------
It seems to make sense to add this information to the agent API as well. Let's use a format similar to the one we'll use here -- I left a comment on that. include/mesos/master/master.proto Lines 348-349 (patched) <https://reviews.apache.org/r/65044/#comment274762> I feel it might make sense to introduce another API call for this, e.g., `GET_OPERATIONS`. The information currently in `GET_AGENTS` is either static or highly aggregated and I feel operations do not really fit here. Additionally, we already have e.g., `GET_TASKS` which appears to be similar. include/mesos/v1/master/master.proto Lines 347 (patched) <https://reviews.apache.org/r/65044/#comment274761> Ditto. src/common/protobuf_utils.cpp Lines 1288-1290 (patched) <https://reviews.apache.org/r/65044/#comment274763> Once we have settled where to transport this information we should create a ticket for adding authorization to this under https://issues.apache.org/jira/browse/MESOS-8374. src/tests/api_tests.cpp Line 166 (original), 166 (patched) <https://reviews.apache.org/r/65044/#comment274759> I think it would be clearer to just use `MasterAPITest::CreateMasterFlags` and then modify the flags we care about. We should explicitly document why we need to change values. src/tests/api_tests.cpp Line 181 (original), 181 (patched) <https://reviews.apache.org/r/65044/#comment274760> Could you add something to the commit message explaining why this is needed? src/tests/api_tests.cpp Lines 312-314 (patched) <https://reviews.apache.org/r/65044/#comment274758> Let's add a comment here explaining that the operation is still pending when we receive the call. - Benjamin Bannier On Jan. 9, 2018, 4:15 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65044/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 4:15 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and > Jie Yu. > > > Bugs: MESOS-8424 > https://issues.apache.org/jira/browse/MESOS-8424 > > > Repository: mesos > > > Description > ------- > > Added the list of operations to the 'GET_AGENTS' response. > > > Diffs > ----- > > include/mesos/master/master.proto f4506fe82ee7c1db77cfb7e94933d5a7f4b024df > include/mesos/v1/master/master.proto > 5cb64df12459b1529306cd33691c003172e4b3ec > src/common/protobuf_utils.cpp fda13072743d57d29cdf7ac3c76c0d42a8d36116 > src/tests/api_tests.cpp 28d46436b9c2fe85bde5bc8def7a840b72d29de3 > > > Diff: https://reviews.apache.org/r/65044/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
