----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195914 -----------------------------------------------------------
include/mesos/agent/agent.proto Lines 72 (patched) <https://reviews.apache.org/r/65044/#comment275274> I'd suggest to sort this right before `GET_TASKS`. include/mesos/agent/agent.proto Lines 422 (patched) <https://reviews.apache.org/r/65044/#comment275275> Ditto. include/mesos/agent/agent.proto Lines 549 (patched) <https://reviews.apache.org/r/65044/#comment275279> Ditto. include/mesos/agent/agent.proto Lines 615 (patched) <https://reviews.apache.org/r/65044/#comment275276> Let's sort this right before `get_tasks`. include/mesos/master/master.proto Lines 67 (patched) <https://reviews.apache.org/r/65044/#comment275277> Let's sort this before `GET_TASKS`. include/mesos/master/master.proto Lines 266 (patched) <https://reviews.apache.org/r/65044/#comment275278> Ditto. include/mesos/master/master.proto Lines 461 (patched) <https://reviews.apache.org/r/65044/#comment275281> Remove one line. include/mesos/master/master.proto Lines 462 (patched) <https://reviews.apache.org/r/65044/#comment275280> Ditto. include/mesos/master/master.proto Lines 512 (patched) <https://reviews.apache.org/r/65044/#comment275282> Ditto. include/mesos/v1/agent/agent.proto Lines 72 (patched) <https://reviews.apache.org/r/65044/#comment275283> Ditto. include/mesos/v1/agent/agent.proto Lines 422 (patched) <https://reviews.apache.org/r/65044/#comment275284> Ditto. include/mesos/v1/agent/agent.proto Lines 549 (patched) <https://reviews.apache.org/r/65044/#comment275285> Ditto. include/mesos/v1/agent/agent.proto Lines 615 (patched) <https://reviews.apache.org/r/65044/#comment275286> Ditto. include/mesos/v1/master/master.proto Lines 65 (patched) <https://reviews.apache.org/r/65044/#comment275287> Ditto. include/mesos/v1/master/master.proto Lines 264 (patched) <https://reviews.apache.org/r/65044/#comment275288> Ditto. include/mesos/v1/master/master.proto Lines 457 (patched) <https://reviews.apache.org/r/65044/#comment275289> Ditto. include/mesos/v1/master/master.proto Lines 507 (patched) <https://reviews.apache.org/r/65044/#comment275290> Ditto. src/master/http.cpp Lines 3761 (patched) <https://reviews.apache.org/r/65044/#comment275291> This seems inconsistent with other handlers. src/tests/api_tests.cpp Lines 1011 (patched) <https://reviews.apache.org/r/65044/#comment275296> Let's mention here that this is 5s. src/tests/api_tests.cpp Lines 1076 (patched) <https://reviews.apache.org/r/65044/#comment275300> We need to assert this to not run into a false negative below. src/tests/api_tests.cpp Lines 1134 (patched) <https://reviews.apache.org/r/65044/#comment275297> Let's expect exactly one operation here. src/tests/api_tests.cpp Lines 6277 (patched) <https://reviews.apache.org/r/65044/#comment275298> Ditto. src/tests/api_tests.cpp Lines 6340 (patched) <https://reviews.apache.org/r/65044/#comment275301> Ditto. src/tests/api_tests.cpp Lines 6398 (patched) <https://reviews.apache.org/r/65044/#comment275302> Ditto. - Benjamin Bannier On Jan. 22, 2018, 3:02 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65044/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 3:02 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and > Jie Yu. > > > Bugs: MESOS-8424 > https://issues.apache.org/jira/browse/MESOS-8424 > > > Repository: mesos > > > Description > ------- > > The 'GET_OPERATIONS' call lists all operations known to master or agent. > > > Diffs > ----- > > include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c > include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd > include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a > include/mesos/v1/master/master.proto > 6759c3004e7e04c0044360b0c54f4438c2f6ec8a > src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 > src/master/master.hpp 05136781b6b1539f37c283e8127e4bafb187a0d1 > src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 > src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 > src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 > > > Diff: https://reviews.apache.org/r/65044/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
