----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review195636 -----------------------------------------------------------
Fix it, then Ship it! src/docker/docker.cpp Lines 752 (patched) <https://reviews.apache.org/r/63860/#comment274899> Nit: You want `// NOLINT(whitespace/line_length)` here. - Andrew Schwartzmeyer On Jan. 12, 2018, 6:34 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63860/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 6:34 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > The Network enum in DockerInfo is specific to Linux containers. `HOST` > doesn't exist on Windows and `BRIDGE` is `NAT` on Windows. The current > default docker network setting was always `HOST`, which broke the > Windows docker executor. Now, if a specific network isn't given, the > network mode will default to `HOST` on Linux agents and `NAT` on Windows > agents. Also, `BRIDGE` mode will be translated to `NAT` on Windows. > > > Diffs > ----- > > src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed > > > Diff: https://reviews.apache.org/r/63860/diff/9/ > > > Testing > ------- > > See https://reviews.apache.org/r/63862/ for test results. > > > Thanks, > > Akash Gupta > >
