> On Jan. 16, 2018, 11:48 p.m., Vinod Kone wrote: > > src/examples/dynamic_reservation_framework.cpp > > Line 41 (original) > > <https://reviews.apache.org/r/64849/diff/3/?file=1940016#file1940016line43> > > > > Any particular reason you deleted these?
Improving consistency as that is the greater goal of this chain. Most other examples did not need them - this example also does not benefit. ie. `cerr` is being referenced once, adding a `using` for that seemed to add more boilerplate than needed. > On Jan. 16, 2018, 11:48 p.m., Vinod Kone wrote: > > src/examples/persistent_volume_framework.cpp > > Line 501 (original) > > <https://reviews.apache.org/r/64849/diff/3/?file=1940017#file1940017line503> > > > > Why did you revert this change introduced in the previous review? Initially, I thought I'ld simply leave it as this todo but then decided to go the extra mile and covering it as well in this chain. > On Jan. 16, 2018, 11:48 p.m., Vinod Kone wrote: > > src/examples/test_http_framework.cpp > > Line 401 (original), 390 (patched) > > <https://reviews.apache.org/r/64849/diff/3/?file=1940018#file1940018line405> > > > > aah you fixed in this review! Yeah, that was a rebase slipup. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/#review195515 ----------------------------------------------------------- On Jan. 17, 2018, 7:01 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64849/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2018, 7:01 p.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, > Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-5362 and MESOS-8357 > https://issues.apache.org/jira/browse/MESOS-5362 > https://issues.apache.org/jira/browse/MESOS-8357 > > > Repository: mesos > > > Description > ------- > > All example frameworks now support authenticating when registering > to the master. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp > 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 > src/examples/persistent_volume_framework.cpp > 71db39d7743d31ea34c2aed579d7a1ef2ed95687 > src/examples/test_http_framework.cpp > 482f65efc15a7bac52c33a57b2b876191249410a > src/tests/persistent_volume_framework_test.sh > 2ab22c03e573d4801c73957f9cad2939b3d3174b > > > Diff: https://reviews.apache.org/r/64849/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
