----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195763 -----------------------------------------------------------
src/slave/slave.cpp Lines 5915-5919 (original), 5998-6002 (patched) <https://reviews.apache.org/r/65231/#comment275065> What about changing these to something like below to be consistent with what you did in `recoverExecutor()`? ``` garbageCollect(path) .onAny(defer(self(), &Self::detachFile, latestPath)) .onAny(defer(self(), &Self::detachFile, virtualLatestPath)); ``` - Qian Zhang On Jan. 19, 2018, 8:48 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65231/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 8:48 a.m.) > > > Review request for mesos, Michael Park, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8460 > https://issues.apache.org/jira/browse/MESOS-8460 > > > Repository: mesos > > > Description > ------- > > Fixed detaching task volume directories of destroyed frameworks. > > > Diffs > ----- > > src/slave/slave.hpp a07f046c7ed980bed3e3d0d2780295727b87ee44 > src/slave/slave.cpp 1672c06894c25e7120bb8a1da15f7d6432eb5954 > > > Diff: https://reviews.apache.org/r/65231/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
