----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195764 -----------------------------------------------------------
Can you or @qian write a unit test that triggered this bug? src/slave/slave.cpp Lines 1029 (patched) <https://reviews.apache.org/r/65231/#comment275066> Custom executors satisfy this check so it's not fool proof. Lets pass `ExecutorInfo` here and check the type instead. src/slave/slave.cpp Lines 1072 (patched) <https://reviews.apache.org/r/65231/#comment275067> ditto. lets pass `ExecutorInfo` here too. - Vinod Kone On Jan. 19, 2018, 1:25 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65231/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 1:25 a.m.) > > > Review request for mesos, Michael Park, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8460 > https://issues.apache.org/jira/browse/MESOS-8460 > > > Repository: mesos > > > Description > ------- > > Fixed detaching task volume directories of destroyed frameworks. > > > Diffs > ----- > > src/slave/slave.hpp a07f046c7ed980bed3e3d0d2780295727b87ee44 > src/slave/slave.cpp 1672c06894c25e7120bb8a1da15f7d6432eb5954 > > > Diff: https://reviews.apache.org/r/65231/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
