-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196653
-----------------------------------------------------------




docs/configuration/master-and-agent.md
Lines 99 (patched)
<https://reviews.apache.org/r/65437/#comment276395>

    Can you also call this out in the home page of documentation 
"http://mesos.apache.org/documentation/latest/";, perhaps in the 
"Administration" section?



docs/fault-domains.md
Lines 15-16 (patched)
<https://reviews.apache.org/r/65437/#comment276378>

    How about
    
    "A fault domain is a 2 level hierarchy of regions and zones."



docs/fault-domains.md
Lines 51 (patched)
<https://reviews.apache.org/r/65437/#comment276380>

    s/slave/agent/



docs/fault-domains.md
Lines 56 (patched)
<https://reviews.apache.org/r/65437/#comment276381>

    s/master,/master/



docs/fault-domains.md
Lines 61 (patched)
<https://reviews.apache.org/r/65437/#comment276382>

    This should be:
    
    * All masters must belong to the same "region" to avoid cross-region quorum 
writes. It is recommended to put them in different zones within that region for 
high availability.



docs/fault-domains.md
Lines 63 (patched)
<https://reviews.apache.org/r/65437/#comment276383>

    s/The default/By default, the/



docs/fault-domains.md
Lines 71 (patched)
<https://reviews.apache.org/r/65437/#comment276384>

    s/connected in a/connected through a/



docs/fault-domains.md
Lines 74-78 (patched)
<https://reviews.apache.org/r/65437/#comment276389>

    In this example, "europe", "na" and "asia" would be regions. 
    
    Also, I would not use cross continental regions as an example because we 
haven't tested the latency limits. Lets use "california", "atlanta" and "new 
york" as regions.
    
    Zones would be racks within the data center.
    
    One of these regions should contain all the masters, preferrably spread 
across zones. Putting them across racks gives them enough isolation for faults 
without sacrificing latency for quorum writes.



docs/fault-domains.md
Lines 80 (patched)
<https://reviews.apache.org/r/65437/#comment276391>

    Non-region-aware frameworks will only receive offers from the primary 
region (region containing masters). They won't get offers from other regions.



docs/fault-domains.md
Lines 88 (patched)
<https://reviews.apache.org/r/65437/#comment276393>

    s/to read the `domain`/to register with `REGION_AWARE` capability/



docs/fault-domains.md
Lines 90-99 (patched)
<https://reviews.apache.org/r/65437/#comment276394>

    This example is a bit too complicated. I would say lets use an example of 
one on-prem data center which is extended by a cloud provider hosted remote 
region.


- Vinod Kone


On Jan. 31, 2018, 5:50 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
>     https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/2/
> 
> 
> Testing
> -------
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Reply via email to