> On Feb. 1, 2018, 10:04 p.m., Benjamin Mahler wrote:
> > Can you include Andy on this review as well? I would love to know what the 
> > suggested approach to this is; if there is some solution in place other 
> > than `#ifdef`s.

Depending on how this error code is used later, we could probably do some sort 
of mapping in 
[`WindowsSocketError`](https://github.com/apache/mesos/blob/1600ebc6901239ae86e4e133c82d3424c56c978e/3rdparty/stout/include/stout/windows/error.hpp#L124)
 (the underlying type of `SocketError` on Windows) so you can manually 
construct it with `ENOTCONN` and its mapped to `WSAENOTCONN` on Windows. Thing 
is, then we'd also need to make sure comparisons are done the same way. Hm...


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65475/#review196687
-----------------------------------------------------------


On Feb. 1, 2018, 9:50 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65475/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2018, 9:50 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 521b0cfbccd3599524b1407ef70880f4538941df 
> 
> 
> Diff: https://reviews.apache.org/r/65475/diff/1/
> 
> 
> Testing
> -------
> 
> make check and internal CI
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Reply via email to