----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196755 -----------------------------------------------------------
Ship it! Per discussion with Andy, I'm ok with either returning ENOTCONN directly, or alternatively you can call `::shutdown` in this case and send out a `SocketError` (if this produces something other than ENOTCONN then we've misunderstood!). - Benjamin Mahler On Feb. 2, 2018, 5:50 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65475/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2018, 5:50 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 521b0cfbccd3599524b1407ef70880f4538941df > > > Diff: https://reviews.apache.org/r/65475/diff/1/ > > > Testing > ------- > > make check and internal CI > > > Thanks, > > Till Toenshoff > >
