----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review196735 -----------------------------------------------------------
src/checks/checker_process.hpp Lines 45 (patched) <https://reviews.apache.org/r/65127/#comment276565> Nit: s/newere/newer src/checks/checker_process.hpp Lines 47 (patched) <https://reviews.apache.org/r/65127/#comment276566> Should we tag this so a push to their image doesn't break us? src/checks/checker_process.cpp Lines 1144-1151 (patched) <https://reviews.apache.org/r/65127/#comment276567> I still feel like there's a better way to output this status code. From command prompt: ``` C:\Users\andrew>pwsh -c (Invoke-WebRequest -Uri google.com -UseBasicParsing -SkipCertificateCheck).StatusCode 200 C:\Users\andrew> ``` What's the problem with the output number? - Andrew Schwartzmeyer On Jan. 30, 2018, 2:18 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65127/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 2:18 a.m.) > > > Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > The network health checks called curl and then executed setns to > enter to container network namespace, which did not work on Windows. > To do the equivalent, Windows nows calls docker run with powershell's > curl equivalent (Invoke-WebRequest) and uses the > network=container:<ID> flag to enter the container's namespace. The > command health check was trivially fixed by replacing the hardcoded > `sh -c`. > > > Diffs > ----- > > src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > > > Diff: https://reviews.apache.org/r/65127/diff/6/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
