----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review196057 -----------------------------------------------------------
src/checks/checker_process.cpp Lines 887-888 (original) <https://reviews.apache.org/r/65127/#comment275577> I think this should stay here, it's weird for `createHttpCheckCmd` to log this. src/checks/checker_process.cpp Lines 991-1004 (patched) <https://reviews.apache.org/r/65127/#comment275574> src/checks/checker_process.cpp Lines 1048-1049 (original) <https://reviews.apache.org/r/65127/#comment275576> I think this should stay here, it's weird for `createTcpCheckCmd` to log this. - Gaston Kleiman On Jan. 16, 2018, 4:09 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65127/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 4:09 p.m.) > > > Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer. > > > Repository: mesos > > > Description > ------- > > The network health checks called curl and then executed setns to > enter to container network namespace, which did not work on Windows. > To do the equivalent, Windows nows calls docker run with powershell's > curl equivalent (Invoke-WebRequest) and uses the > network=container:<ID> flag to enter the container's namespace. > > > Diffs > ----- > > src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > > > Diff: https://reviews.apache.org/r/65127/diff/4/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
