----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65402/#review196757 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/os/windows/dup.hpp Line 49 (original), 43-44 (patched) <https://reviews.apache.org/r/65402/#comment276599> Extra newline here. - Joseph Wu On Jan. 29, 2018, 12:35 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65402/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 12:35 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The CRT API for duplicating file handles is left as-is because > `WindowsFD` currently gets a CRT `int` file descriptor, which > necessitates using `_dup` instead of `DuplicateHandle`. Furthermore, the > latter API does not appear compatible with handles used to redirect > stdout/stderr/stdin for subprocesses. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/dup.hpp > b37aaa6429e0e7b4340e86c078f5c543e443bdcd > > > Diff: https://reviews.apache.org/r/65402/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
