----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65402/ -----------------------------------------------------------
(Updated Feb. 7, 2018, 11:22 a.m.) Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Summary (updated) ----------------- Windows: Used Unicode API to duplicate sockets. Repository: mesos Description ------- The CRT API for duplicating file handles is left as-is because `WindowsFD` currently gets a CRT `int` file descriptor, which necessitates using `_dup` instead of `DuplicateHandle`. Furthermore, the latter API does not appear compatible with handles used to redirect stdout/stderr/stdin for subprocesses. Diffs (updated) ----- 3rdparty/stout/include/stout/os/windows/dup.hpp b37aaa6429e0e7b4340e86c078f5c543e443bdcd Diff: https://reviews.apache.org/r/65402/diff/2/ Changes: https://reviews.apache.org/r/65402/diff/1-2/ Testing ------- Thanks, Andrew Schwartzmeyer
