----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65523/ -----------------------------------------------------------
(Updated Feb. 8, 2018, 12:01 a.m.) Review request for mesos, Greg Mann and Jie Yu. Changes ------- Rebased. Bugs: MESOS-8548 https://issues.apache.org/jira/browse/MESOS-8548 Repository: mesos Description ------- The metrics test unnecessarily set up the disk profile module without providing the profile config file. This may cause the profile module to pull a non-existent file. Also, it could kill the plugin before SLRP connecting to the endpoint, making SLRP wait for 1 minute. Diffs (updated) ----- src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386 Diff: https://reviews.apache.org/r/65523/diff/3/ Changes: https://reviews.apache.org/r/65523/diff/2-3/ Testing ------- sudo make check Thanks, Chun-Hung Hsiao