----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197070 -----------------------------------------------------------
Looks good, just a few minor comments. src/tests/mock_slave.cpp Lines 107-108 (original), 107-109 (patched) <https://reviews.apache.org/r/65497/#comment277182> What's going on here? src/tests/slave_tests.cpp Lines 4926-4927 (patched) <https://reviews.apache.org/r/65497/#comment277178> even after the exeutor has been registered..? I think you want to remove that? src/tests/slave_tests.cpp Lines 4945 (patched) <https://reviews.apache.org/r/65497/#comment277180> "NotSlave"? We should probably have found a way to use the logic from Master::newSlaveId here. src/tests/slave_tests.cpp Lines 5032-5038 (patched) <https://reviews.apache.org/r/65497/#comment277181> Instead of using a slave mock here, can we just expect the executorLost signal from the scheduler? - Benjamin Mahler On Feb. 3, 2018, 1:18 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65497/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2018, 1:18 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8411 > https://issues.apache.org/jira/browse/MESOS-8411 > > > Repository: mesos > > > Description > ------- > > This test verifies that the v1 executor is shutdown if all of its > initial tasks could not be delivered when re-subscribing with > a recovered agent. See MESOS-8411. > > > Diffs > ----- > > src/tests/mesos.hpp a35c68e8645384f6244d17e37cad71373aba6893 > src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908 > src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c > src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f > > > Diff: https://reviews.apache.org/r/65497/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
