> On Feb. 10, 2018, 1:17 a.m., Benjamin Mahler wrote:
> > src/tests/mesos.cpp
> > Line 391 (original), 400 (patched)
> > <https://reviews.apache.org/r/65497/diff/2/?file=1953431#file1953431line400>
> >
> >     I realize this is a copy/paste, but do you know why we don't start() 
> > when mock is true?
> 
> Meng Zhu wrote:
>     If we want to set up expect calls for the agent start code path, we need 
> to (1) create the mock slave instance; (2) setup expectations; (3) start the 
> slave.
> 
> Benjamin Mahler wrote:
>     Ah that make sense, but it's confusing that StartSlave doesn't start the 
> slave if mock=false. Probably we should have only had something like 
> CreateSlave or CreateUnstartedSlave to avoid this confusion?

That makes sense, but it's confusing that StartSlave doesn't start a slave, 
isn't it? =/

Ideally we would have something more accurately named, like CreateSlave.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65497/#review197211
-----------------------------------------------------------


On Feb. 12, 2018, 7:48 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65497/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2018, 7:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8411
>     https://issues.apache.org/jira/browse/MESOS-8411
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the v1 executor is shutdown if all of its
> initial tasks could not be delivered when re-subscribing with
> a recovered agent. See MESOS-8411.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp c5593c25dde18c005f195a1885a8586bc72c849f 
>   src/tests/mesos.cpp ac789297d6aa034121b73e4efc0aafee1ee3b60f 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65497/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Reply via email to