----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197139 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_tests.cpp Lines 4643 (patched) <https://reviews.apache.org/r/65448/#comment277265> s/toLaunchExecutor/launchExecutor/ src/tests/slave_tests.cpp Lines 4681 (patched) <https://reviews.apache.org/r/65448/#comment277266> s/exited/Exited/ src/tests/slave_tests.cpp Lines 4725 (patched) <https://reviews.apache.org/r/65448/#comment277267> Can you also add a test with default executor? And maybe instead of kill task path, try to exercise the authz failure path for that test? Feel free to do it in a subsequent review. More tests that exercise the code paths you changed the better. - Vinod Kone On Feb. 1, 2018, 2:04 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65448/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2018, 2:04 a.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone. > > > Bugs: MESOS-1720 > https://issues.apache.org/jira/browse/MESOS-1720 > > > Repository: mesos > > > Description > ------- > > This test ensures that agent send exited executor message when the > executor is never launched. So that master's executor bookkeeping > entry is removed. See MESOS-1720. > > > Diffs > ----- > > src/tests/slave_tests.cpp b54688add9949b9c4ac2ce3a42503a411e6da09f > > > Diff: https://reviews.apache.org/r/65448/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
