> On Feb. 8, 2018, 5:28 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp
> > Lines 4725 (patched)
> > <https://reviews.apache.org/r/65448/diff/2/?file=1952708#file1952708line4725>
> >
> >     Can you also add a test with default executor? And maybe instead of 
> > kill task path, try to exercise the authz failure path for that test? Feel 
> > free to do it in a subsequent review. More tests that exercise the code 
> > paths you changed the better.

OK, will add more tests in a separate patch.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65448/#review197139
-----------------------------------------------------------


On Jan. 31, 2018, 6:04 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65448/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 6:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
>     https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that agent send exited executor message when the
> executor is never launched. So that master's executor bookkeeping
> entry is removed. See MESOS-1720.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp b54688add9949b9c4ac2ce3a42503a411e6da09f 
> 
> 
> Diff: https://reviews.apache.org/r/65448/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Reply via email to