> On Feb. 12, 2018, 12:13 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp
> > Line 349 (original), 349 (patched)
> > <https://reviews.apache.org/r/65550/diff/2/?file=1955927#file1955927line349>
> >
> >     Not yours, but I think we can kill this. I think this was added pre 
> > multiple task groups support. We should be able to look into the 
> > `containers` map AFAICT.

Killed in https://reviews.apache.org/r/65616/


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65550/#review197304
-----------------------------------------------------------


On Feb. 12, 2018, 3:13 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65550/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2018, 3:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8468
>     https://issues.apache.org/jira/browse/MESOS-8468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor would unnecessarily shutdown if, while launching a
> task group, it gets unsubscribed after having successfully launched the
> task group's containers.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea 
> 
> 
> Diff: https://reviews.apache.org/r/65550/diff/3/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Reply via email to