-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65550/#review197217
-----------------------------------------------------------




src/launcher/default_executor.cpp
Lines 539-546 (original), 537 (patched)
<https://reviews.apache.org/r/65550/#comment277354>

    Since the guard above was removed, this CHECK could potentially be hit now.



src/launcher/default_executor.cpp
Line 558 (original), 549 (patched)
<https://reviews.apache.org/r/65550/#comment277357>

    What happens when the executor is disconnected (as is now allowed) and 
attempts to launch some health checks?
    
    Any nested command checks would definitely fail.  But I suppose this is 
better than shutting down the executor.
    
    Seems like you need to either delay the creation of the health checks or 
pause them immediately after creation.



src/launcher/default_executor.cpp
Lines 626-631 (original), 617-622 (patched)
<https://reviews.apache.org/r/65550/#comment277359>

    This will be dropped if the executor isn't subscribed.  And as far as I can 
tell, this status update is not sent in any other location


- Joseph Wu


On Feb. 7, 2018, 11 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65550/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 11 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8468
>     https://issues.apache.org/jira/browse/MESOS-8468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor would unnecessarily shutdown if, while launching a
> task group, it gets unsubscribed after having successfully launched the
> task group's containers.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea 
> 
> 
> Diff: https://reviews.apache.org/r/65550/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Reply via email to