> On Feb. 12, 2018, 12:37 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Line 786 (original), 788 (patched) > > <https://reviews.apache.org/r/65551/diff/4/?file=1955928#file1955928line805> > > > > If a launch for nested container fails, don't we get `NotFound`?
This didn't occur while doing manual testing, and isn't triggered by the test added in https://reviews.apache.org/r/65552. However I took a look at the Mesos containerizer's code, and there are cases in which a 404 NOT FOUND could be returned, so I updated `waited()` to handle this. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197314 ----------------------------------------------------------- On Feb. 9, 2018, 10:35 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65551/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2018, 10:35 p.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod > Kone. > > > Bugs: MESOS-8468 > https://issues.apache.org/jira/browse/MESOS-8468 > > > Repository: mesos > > > Description > ------- > > The default executor would be completely shutdown on a > `LAUNCH_NESTED_CONTAINER` failure. > > This patch makes it kill the affected task group instead of shutting > down and killing all task groups. > > > Diffs > ----- > > src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea > > > Diff: https://reviews.apache.org/r/65551/diff/4/ > > > Testing > ------- > > `sudo make check` on GNU/Linux > > Regression test on https://reviews.apache.org/r/65552/ > > > Thanks, > > Gaston Kleiman > >
